Bug 226768 - Move some hand rolled CSSProperty predicates to be generated based on new CSSProperties.json properties
Summary: Move some hand rolled CSSProperty predicates to be generated based on new CSS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-08 07:41 PDT by Sam Weinig
Modified: 2021-06-08 09:36 PDT (History)
11 users (show)

See Also:

Attachments
Patch (34.11 KB, patch)
2021-06-08 07:45 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-06-08 07:41:18 PDT 
Move some hand rolled CSSProperty predicates to be generated based on new CSSProperties.json properties
Comment 1 Sam Weinig 2021-06-08 07:45:27 PDT 
Created attachment 430840 [details]
Patch
Comment 2 Antti Koivisto 2021-06-08 07:57:18 PDT 
Comment on attachment 430840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430840&action=review

> Source/WebCore/css/CSSProperties.json:101
> +        "CSSProperty::isDescriptorOnly().",

Wonder if should make these standalone functions...
Comment 3 EWS 2021-06-08 09:35:16 PDT 
Committed r278611 (238600@main): <https://commits.webkit.org/238600@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430840 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-08 09:36:20 PDT 
<rdar://problem/79015696>