Bug 226754 – iOS - VoiceOver reads the old heading text when updated with heading.firstChild.data.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

iOS - VoiceOver reads the old heading text when updated with heading.firstChild.data.

[Radar WebKit Bug Importer]

<rdar://problem/78979269>

[Andres Gonzalez]

rdar://44949563

[Andres Gonzalez]

Created attachment 430804 [details]
Patch

[chris fleizach]

Comment on attachment 430804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430804&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:689
> +                String headingLabel = parent->descriptionAttributeValue();

can use auto here

[Andres Gonzalez]

Created attachment 430937 [details]
Patch

[Andres Gonzalez]

Created attachment 430938 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #4)
> Comment on attachment 430804 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430804&action=review
> 
> > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:689
> > +                String headingLabel = parent->descriptionAttributeValue();
> 
> can use auto here

Done, although not a fan of using auto instead of types like String, unless there is a reason for it, don't think it gains in readability.

[chris fleizach]

Comment on attachment 430938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430938&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1191
> +    if (backingObject->roleValue() == AccessibilityRole::StaticText) {

Can we check here if it has the heading trait before looking for the ancestor?

[Andres Gonzalez]

Created attachment 430964 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #8)
> Comment on attachment 430938 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430938&action=review
> 
> > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1191
> > +    if (backingObject->roleValue() == AccessibilityRole::StaticText) {
> 
> Can we check here if it has the heading trait before looking for the
> ancestor?

Yes, done.

[EWS]

Committed r278683 (238660@main): <https://commits.webkit.org/238660@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430964 [details].