Bug 226748 - Drop legacy EventLoopEventQueue class
Summary: Drop legacy EventLoopEventQueue class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-07 17:45 PDT by Chris Dumez
Modified: 2021-06-08 21:34 PDT (History)
19 users (show)

See Also:


Attachments
Patch (37.50 KB, patch)
2021-06-08 09:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (38.40 KB, patch)
2021-06-08 09:59 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (43.68 KB, patch)
2021-06-08 10:28 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (43.95 KB, patch)
2021-06-08 10:40 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (44.61 KB, patch)
2021-06-08 11:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (46.61 KB, patch)
2021-06-08 11:08 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (48.06 KB, patch)
2021-06-08 11:35 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (48.08 KB, patch)
2021-06-08 18:29 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-06-07 17:45:38 PDT
Drop legacy EventLoopEventQueue class and have HTMLMediaElement use the HTML event loop directly.
Comment 1 Chris Dumez 2021-06-08 09:49:46 PDT
Created attachment 430852 [details]
Patch
Comment 2 Chris Dumez 2021-06-08 09:59:16 PDT
Created attachment 430854 [details]
Patch
Comment 3 Chris Dumez 2021-06-08 10:28:41 PDT
Created attachment 430858 [details]
Patch
Comment 4 Chris Dumez 2021-06-08 10:40:59 PDT
Created attachment 430861 [details]
Patch
Comment 5 Chris Dumez 2021-06-08 11:01:42 PDT
Created attachment 430864 [details]
Patch
Comment 6 Chris Dumez 2021-06-08 11:08:24 PDT
Created attachment 430865 [details]
Patch
Comment 7 Chris Dumez 2021-06-08 11:35:20 PDT
Created attachment 430869 [details]
Patch
Comment 8 Darin Adler 2021-06-08 18:19:51 PDT
Comment on attachment 430869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430869&action=review

> Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:48
> -            *reason = "TextTrackCue is firing event listeners";
> +            *reason = "ActiveDOMObject with pending activity";

Why is it better to have this message be vague?

Can we share this constant string "ActiveDOMObject with pending activity" with uses elsewhere?

> Source/WebCore/html/track/DataCue.cpp:75
> +    dataCue->suspendIfNeeded();

A little frustrating to have to add so much boilerplate with all these calls.
Comment 9 Chris Dumez 2021-06-08 18:21:53 PDT
Comment on attachment 430869 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430869&action=review

>> Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:48
>> +            *reason = "ActiveDOMObject with pending activity";
> 
> Why is it better to have this message be vague?
> 
> Can we share this constant string "ActiveDOMObject with pending activity" with uses elsewhere?

I copied the code from the generated bindings code for [ActiveDOMObject]. I don't have to keep the message so generic though, I'll replace ActiveDOMObject with TextTrackCue.
Comment 10 Chris Dumez 2021-06-08 18:29:23 PDT
Created attachment 430931 [details]
Patch
Comment 11 EWS 2021-06-08 21:33:12 PDT
Committed r278645 (238627@main): <https://commits.webkit.org/238627@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430931 [details].
Comment 12 Radar WebKit Bug Importer 2021-06-08 21:34:19 PDT
<rdar://problem/79054988>