Bug 226736 – [Modern Media Controls] upstream new features

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Devin Rousso]

.

[Radar WebKit Bug Importer]

<rdar://problem/78957464>

[Devin Rousso]

Created attachment 430777 [details]
Patch

[Peng Liu]

Comment on attachment 430777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430777&action=review

> LayoutTests/platform/mac-wk2/TestExpectations:22
> +media/modern-media-controls/overflow-support [ Pass ]

Can we enable the test for iOS as well?

[Devin Rousso]

Comment on attachment 430777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430777&action=review

>> LayoutTests/platform/mac-wk2/TestExpectations:22
>> +media/modern-media-controls/overflow-support [ Pass ]
> 
> Can we enable the test for iOS as well?

iOS requires some new functionality that's not yet in EWS bots (see `#define ENABLE_MEDIA_CONTROLS_CONTEXT_MENUS`).  These tests are enabled on the internal bots in the meantime.

[Eric Carlson]

Comment on attachment 430777 [details]
Patch

r=me once the bots agree

[Devin Rousso]

Created attachment 430814 [details]
Patch

just tried building with the latest public SDK in an effort to match the bots and the test passed just fine :/

[EWS]

Committed r278618 (238603@main): <https://commits.webkit.org/238603@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430814 [details].

[Truitt Savell]

the new test media/modern-media-controls/overflow-support/chapters.html

added in https://trac.webkit.org/changeset/278618/webkit

is a constant timeout: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Foverflow-support%2Fchapters.html

This is impeding ews, can this be fixed quickly or can we revert this change until it is fixed? 

Tracking bug: https://bugs.webkit.org/show_bug.cgi?id=226828