Bug 22673 – Added support for the assertion (?=) and inverted assertion (?!) atoms in WREC.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Geoffrey Garen]

Patch coming.

[Geoffrey Garen]

Created attachment 25763 [details]
patch

[Darin Adler]

Comment on attachment 25763 [details]
patch

> +    switch (type) {
> +    case Generator::Assertion: {
> +        m_generator.generateParenthesesAssertion(failures);
> +        break;
> +    }
> +    case Generator::InvertedAssertion: {
> +        m_generator.generateParenthesesInvertedAssertion(failures);
> +        break;
> +    }
> +    default: {
> +        m_error = UnsupportedParentheses;
> +        return false;
> +    }
> +    }

We normally indent cases from the switch. We normally use braces for cases only when they are needed.

> +    switch (q.type) {
> +    case Quantifier::None: {
> +        return true;
> +    }
> +    case Quantifier::Greedy: {
> +        m_error = UnsupportedParentheses;
> +        return false;
> +    }
> +    case Quantifier::NonGreedy: {
> +        m_error = UnsupportedParentheses;
> +        return false;
> +    }
> +    case Quantifier::Error: {
> +        return false;
> +    }
> +    }

Ditto.

r=me

[Geoffrey Garen]

Committed revision 39030.