Bug 226729 – [css-flexbox] Tables inside flexbox do not account for their borders correctly

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Layout and Rendering

[Felipe Erias]

An empty table inside a flexbox tries to follow its overriding logical height. However, in so doing it may fail to account correctly for its border.

This means that the final logical height of the element can be wrong when the border is not empty.

Test case:

imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1.html

[Felipe Erias]

Created attachment 430745 [details]
Patch

[Felipe Erias]

Created attachment 431181 [details]
Patch

[Felipe Erias]

Updated the title because this turned out to be a more general problem.

When a table's height or width is set though an attribute of the <table> tag, that value will include borders and padding. When it is set through CSS, that will depend on the value of the table's "box-sizing" property.

With the last patch, RenderTable will check for the presence of those attributes in the <table> tag as well as the value of "box-sizing" before deciding how to handle the table's border and padding.

This fixes:
  imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html

I suspect that table-as-item-inflexible-in-column-2.html also fails for a similar reason.

[Radar WebKit Bug Importer]

<rdar://problem/79287201>

[Tim Nguyen (:ntim)]

Comment on attachment 431181 [details]
Patch

Cleaning r? flag, since it does not build, and it is quite old at this point.

[Ahmad Saleem]

Safari Technology Preview 172 is passing both tests:

https://wpt.fyi/results/css/css-flexbox?label=master&label=experimental&aligned=&q=table-as-item-inflexible-in-column

Do we need to track this anymore?

[Brent Fulgham]

Closing based on Ahmad's testing.