Bug 226714 - [GStreamer] Remove spurious assert in WTF::DataMutex
Summary: [GStreamer] Remove spurious assert in WTF::DataMutex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-07 01:44 PDT by Alicia Boya García
Modified: 2021-06-16 18:52 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2021-06-07 01:44 PDT, Alicia Boya García 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2021-06-07 01:44:08 PDT 
Remove DATA_MUTEX_CHECK(!mutex().isHeld()); from the DataMutexLocker
        constructor, introduced in r278248.

        Trying to lock a currently held mutex is not an error condition that
        should crash the process, it will just wait for its turn to lock it.
Comment 1 Alicia Boya García 2021-06-07 01:44:52 PDT 
Created attachment 430725 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2021-06-07 04:27:25 PDT 
lgtm
Comment 3 EWS 2021-06-07 04:40:57 PDT 
Committed r278555 (238553@main): <https://commits.webkit.org/238553@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430725 [details].
Comment 4 Fujii Hironori 2021-06-16 18:52:26 PDT 
This change causes a test failure.
  Bug 227021 – [GTK] TestWTF:WTF_DataMutex.DoubleLockDeathTest is timing out