Bug 226705 - Delete some recently-obsoleted files
Summary: Delete some recently-obsoleted files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-06 19:44 PDT by Darin Adler
Modified: 2021-06-15 12:15 PDT (History)
15 users (show)

See Also:

Attachments
Patch (12.02 KB, patch)
2021-06-06 19:45 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (12.47 KB, patch)
2021-06-06 19:53 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (12.98 KB, patch)
2021-06-06 22:36 PDT, Darin Adler 		cdumez: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-06-06 19:44:30 PDT 
Delete some recently-obsoleted files
Comment 1 Darin Adler 2021-06-06 19:45:02 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2021-06-06 19:53:15 PDT 
Created attachment 430707 [details]
Patch
Comment 3 Darin Adler 2021-06-06 20:37:01 PDT 
No idea how deleting this files triggered these errors, but clearly need a TextStream.h include somewhere.
Comment 4 Chris Dumez 2021-06-06 20:44:01 PDT 
Comment on attachment 430707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430707&action=review

> Source/WebCore/Sources.txt:-727
> -css/CSSCustomIdentValue.cpp

Oh the joy of dropping or adding a file from sources.txt and having to add includes to fix the build…
Comment 5 Darin Adler 2021-06-06 22:32:05 PDT 
Ah, didn’t realize I had removed something from the unified sources list. Makes total sense now.
Comment 6 Darin Adler 2021-06-06 22:36:14 PDT 
Created attachment 430711 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2021-06-13 19:45:16 PDT 
<rdar://problem/79271072>
Comment 8 EWS 2021-06-14 11:39:49 PDT 
Tools/Scripts/svn-apply failed to apply attachment 430711 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 9 Darin Adler 2021-06-15 12:15:40 PDT 
Committed r278891 (238833@main): <https://commits.webkit.org/238833@main>