WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226705
Delete some recently-obsoleted files
https://bugs.webkit.org/show_bug.cgi?id=226705
Summary
Delete some recently-obsoleted files
Darin Adler
Reported
2021-06-06 19:44:30 PDT
Delete some recently-obsoleted files
Attachments
Patch
(12.02 KB, patch)
2021-06-06 19:45 PDT
,
Darin Adler
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(12.47 KB, patch)
2021-06-06 19:53 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(12.98 KB, patch)
2021-06-06 22:36 PDT
,
Darin Adler
cdumez
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2021-06-06 19:45:02 PDT
Comment hidden (obsolete)
Created
attachment 430706
[details]
Patch
Darin Adler
Comment 2
2021-06-06 19:53:15 PDT
Created
attachment 430707
[details]
Patch
Darin Adler
Comment 3
2021-06-06 20:37:01 PDT
No idea how deleting this files triggered these errors, but clearly need a TextStream.h include somewhere.
Chris Dumez
Comment 4
2021-06-06 20:44:01 PDT
Comment on
attachment 430707
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=430707&action=review
> Source/WebCore/Sources.txt:-727 > -css/CSSCustomIdentValue.cpp
Oh the joy of dropping or adding a file from sources.txt and having to add includes to fix the build…
Darin Adler
Comment 5
2021-06-06 22:32:05 PDT
Ah, didn’t realize I had removed something from the unified sources list. Makes total sense now.
Darin Adler
Comment 6
2021-06-06 22:36:14 PDT
Created
attachment 430711
[details]
Patch
Radar WebKit Bug Importer
Comment 7
2021-06-13 19:45:16 PDT
<
rdar://problem/79271072
>
EWS
Comment 8
2021-06-14 11:39:49 PDT
Tools/Scripts/svn-apply failed to apply
attachment 430711
[details]
to trunk. Please resolve the conflicts and upload a new patch.
Darin Adler
Comment 9
2021-06-15 12:15:40 PDT
Committed
r278891
(
238833@main
): <
https://commits.webkit.org/238833@main
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug