Bug 226704 – [Cocoa] Find-in-page should match text inside image overlays

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 430709 [details]
Patch

[Tim Horton]

Comment on attachment 430709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430709&action=review

> Source/WebKit/WebProcess/WebPage/FindController.cpp:379
> +        textIndicatorOptions.add({ TextIndicatorOption::PaintAllContent, TextIndicatorOption::PaintBackgrounds });

I wonder (separately) if we can infer some of these options in TI and remove some complexity from the clients. Like, give it more reasonable/intelligent defaults and delete some of the TextIndicatorOption values. Would need a careful pass over all the clients, though.

[Wenson Hsieh]

Comment on attachment 430709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430709&action=review

Thanks for the review!

>> Source/WebKit/WebProcess/WebPage/FindController.cpp:379
>> +        textIndicatorOptions.add({ TextIndicatorOption::PaintAllContent, TextIndicatorOption::PaintBackgrounds });
> 
> I wonder (separately) if we can infer some of these options in TI and remove some complexity from the clients. Like, give it more reasonable/intelligent defaults and delete some of the TextIndicatorOption values. Would need a careful pass over all the clients, though.

That’s a good point. I think in the case of look up and find in image overlays, this would help to alleviate some duplicate code, but (as you mentioned) it would require some careful vetting to make this change for all textindicators.

A halfway point might be something like a helper function in TextIndicator that adjusts a given set of TI options, given a range.

[EWS]

Committed r278560 (238558@main): <https://commits.webkit.org/238558@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430709 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78945509>