Bug 226684 – Unexport llvm coverage symbols to fix build

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Unexport llvm coverage symbols to fix build

Even after the fix in r278444 for Bug 226562, some internal projects still failed to build during the GenerateTAPI build phase:

    error: headers don't have symbol '(weak-def) ___llvm_profile_filename'
    error: headers don't have symbol '(weak-def) ___llvm_profile_raw_version'
    error: headers don't have symbol '(weak-def) _lprofDirMode'

So instead of just ignoring these weak external symbols in check-for-weak-vtables-and-externals, we need to unexport them.

[Radar WebKit Bug Importer]

<rdar://problem/78906691>

[David Kilzer (:ddkilzer)]

Created attachment 430650 [details]
Patch v1

[EWS]

Committed r278536 (238534@main): <https://commits.webkit.org/238534@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430650 [details].

[David Kilzer (:ddkilzer)]

(In reply to EWS from comment #3)
> Committed r278536 (238534@main): <https://commits.webkit.org/238534@main>

Follow-up fix for wrong comment character in Tools/coverage/coverage.xcconfig file:

Committed r278536: <https://trac.webkit.org/r278536>

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #4)
> (In reply to EWS from comment #3)
> > Committed r278536 (238534@main): <https://commits.webkit.org/238534@main>
> 
> Follow-up fix for wrong comment character in
> Tools/coverage/coverage.xcconfig file:
> 
> Committed r278536: <https://trac.webkit.org/r278536>

Committed r278987: <https://trac.webkit.org/r278987>

(Copied and pasted the wrong commit revision!)