Bug 226675 - [WebXR] WebXR on Cocoa doesn't work with webgl 1 contexts
Summary: [WebXR] WebXR on Cocoa doesn't work with webgl 1 contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-04 21:06 PDT by Dean Jackson
Modified: 2021-06-05 14:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.50 KB, patch)
2021-06-04 21:12 PDT, Dean Jackson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-06-04 21:06:31 PDT 
[WebXR] WebXR on Cocoa doesn't work with webgl 1 contexts
Comment 1 Dean Jackson 2021-06-04 21:06:56 PDT 
rdar://78699437
Comment 2 Dean Jackson 2021-06-04 21:12:58 PDT 
Created attachment 430641 [details]
Patch
Comment 3 Sam Weinig 2021-06-05 08:18:32 PDT 
Comment on attachment 430641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430641&action=review

> Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:355
> +            // With IOSurfaces we'll do this each frame.

It would be nice if we could make these work the same for both at some point.
Comment 4 Dean Jackson 2021-06-05 14:28:30 PDT 
Committed r278526 (238525@main): <https://commits.webkit.org/238525@main>