WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226674
Optimize a few call sites creating SharedBuffer objects
https://bugs.webkit.org/show_bug.cgi?id=226674
Summary
Optimize a few call sites creating SharedBuffer objects
Chris Dumez
Reported
2021-06-04 20:43:11 PDT
Optimization a few call sites creating SharedBuffer objects.
Attachments
Patch
(9.53 KB, patch)
2021-06-04 20:44 PDT
,
Chris Dumez
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2021-06-04 20:44:53 PDT
Created
attachment 430640
[details]
Patch
Darin Adler
Comment 2
2021-06-04 21:18:02 PDT
Comment on
attachment 430640
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=430640&action=review
> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:-1249 > - overrideData = SharedBuffer::create(content.utf8().data(), content.utf8().length());
Wow, we should grep for this mistake, even when it doesn’t involve SharedBuffer.
> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1651 > + auto sharedBuffer = SharedBuffer::create(data.data(), data.size());
Seems a little sad that we copy in all these IPC cases. But I guess getting lifetime right would be tricky if we used more of a data view instead of a copy.
EWS
Comment 3
2021-06-04 22:46:03 PDT
Committed
r278523
(
238522@main
): <
https://commits.webkit.org/238522@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 430640
[details]
.
Radar WebKit Bug Importer
Comment 4
2021-06-04 22:47:15 PDT
<
rdar://problem/78899496
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug