Bug 226665 – [GLib] Rename WebKitWebExtension to WebKitWebProcessExtension

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

"WebExtension" is nowadays understood to mean something entirely different from our WebKitWebExtensions. It would be less confusing if we rename WebKitWebExtension to WebKitInjectedBundle during the GTK 4 API break.

[Carlos Garcia Campos]

I agree extension is confusing, but I'm not sure injected bundle is less confusing. I think cocoa api uses something like web process plugin. But again, plugin can be confused with npapi plugin.

[Adrian Perez]

(In reply to Carlos Garcia Campos from comment #1)
> I agree extension is confusing, but I'm not sure injected bundle is less
> confusing. I think cocoa api uses something like web process plugin. But
> again, plugin can be confused with npapi plugin.

Nobody should need to know at the API level what an injected bundle is.
Something like WebProcessAddon or WebProcessExtension should be clear
enough without falling in the pitfall of making people think of NPAPI
plug-ins, I would say.

[Michael Catanzaro]

WONTFIX because this API will need to go away.

[Michael Catanzaro]

Reopening as per https://bugs.webkit.org/show_bug.cgi?id=243906#c1

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/11030

[EWS]

Committed 261349@main (e60e9083903f): <https://commits.webkit.org/261349@main>

Reviewed commits have been landed. Closing PR #11030 and removing active labels.

[Diego Pino]

Build bot WPE-Linux-64-bit-Release-Ubuntu-2004-Build is failing after this change:

https://build.webkit.org/#/builders/596/builds/7851

```
FAILED: Tools/TestWebKitAPI/glib/CMakeFiles/WebProcessTest.dir/__/Tests/WebKitGLib/FrameTest.cpp.o 
/bin/c++  -DBUILDING_WEBKIT=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WPE__=1 -DBWRAP_EXECUTABLE=\"/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WPE\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DNO_GTEST_USAGE -DPAS_BMALLOC=1 -DUSE_SYSTEM_EGL -DWEBKIT_EXEC_PATH=\"/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/Release/bin\" -DWEBKIT_INJECTED_BUNDLE_PATH=\"/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/Release/lib\" -DWEBKIT_SRC_DIR=\"/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2004-Build/build\" -DWEBKIT_TEST_PLUGIN_DIR=\"/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/Release/lib/plugins\" -DWEBKIT_TEST_RESOURCES_DIR=\"/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/Release/bin/TestWebKitAPI/WPE/resources\" -DWEBKIT_TEST_WEB_PROCESS_EXTENSIONS_DIR=\"/home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2004-Build/build/WebKitBuild/Release/lib/WPEAPITests\" -DWebProcessTest_EXPORTS -I. -I../../Tools/TestWebKitAPI -I../../Tools/TestWebKitAPI/Tests/WebKitGLib -I../../Tools/TestWebKitAPI/glib/WebKitGLib -IJavaScriptCoreGLib/DerivedSources -IJavaScriptCoreGLib/Headers -IJavaScriptCore/Headers -IJavaScriptCore/PrivateHeaders -IPAL/Headers -IWTF/Headers -IDerivedSources/WebKit/wpe -IDerivedSources/ForwardingHeaders/wpe -IDerivedSources/ForwardingHeaders/wpe-dom -IDerivedSources/ForwardingHeaders/wpe-web-process-extension -IDerivedSources/ForwardingHeaders -IWebCore/PrivateHeaders -Ibmalloc/Headers -IDerivedSources/WebKit -IDerivedSources/WebKit/include -I../../Source/WebKit -I../../Source/WebKit/GPUProcess -I../../Source/WebKit/GPUProcess/graphics -I../../Source/WebKit/GPUProcess/graphics/WebGPU -I../../Source/WebKit/GPUProcess/media -I../../Source/WebKit/GPUProcess/webrtc -I../../Source/WebKit/NetworkProcess -I../../Source/WebKit/NetworkProcess/Classifier -I../../Source/WebKit/NetworkProcess/Cookies -I../../Source/WebKit/NetworkProcess/CustomProtocols -I../../Source/WebKit/NetworkProcess/Downloads -I../../Source/WebKit/NetworkProcess/FileAPI -I../../Source/WebKit/NetworkProcess/IndexedDB -I../../Source/WebKit/NetworkProcess/Notifications -I../../Source/WebKit/NetworkProcess/PrivateClickMeasurement -I../../Source/WebKit/NetworkProcess/ServiceWorker -I../../Source/WebKit/NetworkProcess/SharedWorker -I../../Source/WebKit/NetworkProcess/cache -I../../Source/WebKit/NetworkProcess/storage -I../../Source/WebKit/NetworkProcess/watchos -I../../Source/WebKit/NetworkProcess/webrtc -I../../Source/WebKit/Platform -I../../Source/WebKit/Platform/IPC -I../../Source/WebKit/PluginProcess -I../../Source/WebKit/Shared -I../../Source/WebKit/Shared/API -I../../Source/WebKit/Shared/API/c -I../../Source/WebKit/Shared/ApplePay -I../../Source/WebKit/Shared/Authentication -I../../Source/WebKit/Shared/CoreIPCSupport -I../../Source/WebKit/Shared/Databases -I../../Source/WebKit/Shared/Databases/IndexedDB -I../../Source/WebKit/Shared/FileAPI -I../../Source/WebKit/Shared/Gamepad -I../../Source/WebKit/Shared/Notifications -I../../Source/WebKit/Shared/Plugins -I../../Source/WebKit/Shared/Plugins/Netscape -I../../Source/WebKit/Shared/Plugins/Netscape/x11 -I../../Source/WebKit/Shared/RemoteLayerTree -I../../Source/WebKit/Shared/WebGPU -I../../Source/WebKit/Shared/WebsiteData -I../../Source/WebKit/Shared/XR -I../../Source/WebKit/UIProcess -I../../Source/WebKit/UIProcess/API -I../../Source/WebKit/UIProcess/API/C -I../../Source/WebKit/UIProcess/API/cpp -I../../Source/WebKit/UIProcess/Authentication -I../../Source/WebKit/UIProcess/Automation -I../../Source/WebKit/UIProcess/Downloads -I../../Source/WebKit/UIProcess/Gamepad -I../../Source/WebKit/UIProcess/GPU -I../../Source/WebKit/UIProcess/Inspector -I../../Source/WebKit/UIProcess/Inspector/Agents -I../../Source/WebKit/UIProcess/Launcher -I../../Source/WebKit/UIProcess/Media -I../../Source/WebKit/UIProcess/Network -I../../Source/WebKit/UIProcess/Network/CustomProtocols -I../../Source/WebKit/UIProcess/Notifications -I../../Source/WebKit/UIProcess/Plugins -I../../Source/WebKit/UIProcess/RemoteLayerTree -I../../Source/WebKit/UIProcess/UserContent -I../../Source/WebKit/UIProcess/WebAuthentication -I../../Source/WebKit/UIProcess/WebAuthentication/Mock -I../../Source/WebKit/UIProcess/WebsiteData -I../../Source/WebKit/UIProcess/XR -I../../Source/WebKit/WebProcess -I../../Source/WebKit/WebProcess/ApplePay -I../../Source/WebKit/WebProcess/ApplicationCache -I../../Source/WebKit/WebProcess/Automation -I../../Source/WebKit/WebProcess/Cache -I../../Source/WebKit/WebProcess/Databases -I../../Source/WebKit/WebProcess/Databases/IndexedDB -I../../Source/WebKit/WebProcess/EncryptedMedia -I../../Source/WebKit/WebProcess/FileAPI -I../../Source/WebKit/WebProcess/FullScreen -I../../Source/WebKit/WebProcess/Gamepad -I../../Source/WebKit/WebProcess/Geolocation -I../../Source/WebKit/WebProcess/GPU -I../../Source/WebKit/WebProcess/GPU/graphics -I../../Source/WebKit/WebProcess/GPU/graphics/WebGPU -I../../Source/WebKit/WebProcess/GPU/media -I../../Source/WebKit/WebProcess/GPU/webrtc -I../../Source/WebKit/WebProcess/IconDatabase -I../../Source/WebKit/WebProcess/InjectedBundle -I../../Source/WebKit/WebProcess/InjectedBundle/API -I../../Source/WebKit/WebProcess/InjectedBundle/API/c -I../../Source/WebKit/WebProcess/InjectedBundle/DOM -I../../Source/WebKit/WebProcess/Inspector -I../../Source/WebKit/WebProcess/Launching -I../../Source/WebKit/WebProcess/MediaCache -I../../Source/WebKit/WebProcess/MediaStream -I../../Source/WebKit/WebProcess/Model -I../../Source/WebKit/WebProcess/Network -I../../Source/WebKit/WebProcess/Network/webrtc -I../../Source/WebKit/WebProcess/Notifications -I../../Source/WebKit/WebProcess/OriginData -I../../Source/WebKit/WebProcess/Plugins -I../../Source/WebKit/WebProcess/Plugins/Netscape -I../../Source/WebKit/WebProcess/ResourceCache -I../../Source/WebKit/WebProcess/Speech -I../../Source/WebKit/WebProcess/Storage -I../../Source/WebKit/WebProcess/UserContent -I../../Source/WebKit/WebProcess/WebCoreSupport -I../../Source/WebKit/WebProcess/WebPage -I../../Source/WebKit/WebProcess/WebPage/RemoteLayerTree -I../../Source/WebKit/WebProcess/WebStorage -I../../Source/WebKit/WebProcess/XR -I../../Source -I../../WebKitLibraries -I../../Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM -I../../Source/WebKit/WebProcess/InjectedBundle/API/wpe/DOM -I../../Source/WebKit/NetworkProcess/glib -I../../Source/WebKit/NetworkProcess/soup -I../../Source/WebKit/Platform/IPC/glib -I../../Source/WebKit/Platform/IPC/unix -I../../Source/WebKit/Platform/classifier -I../../Source/WebKit/Platform/generic -I../../Source/WebKit/Shared/API/c/wpe -I../../Source/WebKit/Shared/API/glib -I../../Source/WebKit/Shared/CoordinatedGraphics -I../../Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor -I../../Source/WebKit/Shared/glib -I../../Source/WebKit/Shared/libwpe -I../../Source/WebKit/Shared/soup -I../../Source/WebKit/UIProcess/API/C/cairo -I../../Source/WebKit/UIProcess/API/C/glib -I../../Source/WebKit/UIProcess/API/C/wpe -I../../Source/WebKit/UIProcess/API/glib -I../../Source/WebKit/UIProcess/API/libwpe -I../../Source/WebKit/UIProcess/API/wpe -I../../Source/WebKit/UIProcess/CoordinatedGraphics -I../../Source/WebKit/UIProcess/Inspector/glib -I../../Source/WebKit/UIProcess/Launcher/glib -I../../Source/WebKit/UIProcess/Launcher/libwpe -I../../Source/WebKit/UIProcess/Notifications/glib -I../../Source/WebKit/UIProcess/geoclue -I../../Source/WebKit/UIProcess/gstreamer -I../../Source/WebKit/UIProcess/linux -I../../Source/WebKit/UIProcess/soup -I../../Source/WebKit/UIProcess/wpe -I../../Source/WebKit/WebProcess/InjectedBundle/API/glib -I../../Source/WebKit/WebProcess/InjectedBundle/API/wpe -I../../Source/WebKit/WebProcess/WebCoreSupport/soup -I../../Source/WebKit/WebProcess/WebPage/CoordinatedGraphics -I../../Source/WebKit/WebProcess/WebPage/libwpe -I../../Source/WebKit/WebProcess/WebPage/wpe -I../../Source/WebKit/WebProcess/glib -I../../Source/WebKit/WebProcess/soup -IANGLE/Headers -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/gstreamer-1.0 -isystem /usr/include/orc-0.4 -isystem /usr/include/libsoup-2.4 -isystem /usr/include/wpe-fdo-1.0 -isystem /usr/include/cairo -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/wpe-1.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem /usr/include/libxml2 -isystem /usr/include/openjpeg-2.3 -fdiagnostics-color=always -Wextra -Wall -pipe -fmax-errors=20 -Wno-odr -Wno-stringop-overflow -Wno-nonnull -Wno-array-bounds -Wno-expansion-to-defined -Wno-noexcept-type -Wno-uninitialized -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare  -fno-strict-aliasing -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -Wno-unused-parameter -DWPE_ENABLE_XKB=1 -pthread -std=c++2a -MD -MT Tools/TestWebKitAPI/glib/CMakeFiles/WebProcessTest.dir/__/Tests/WebKitGLib/FrameTest.cpp.o -MF Tools/TestWebKitAPI/glib/CMakeFiles/WebProcessTest.dir/__/Tests/WebKitGLib/FrameTest.cpp.o.d -o Tools/TestWebKitAPI/glib/CMakeFiles/WebProcessTest.dir/__/Tests/WebKitGLib/FrameTest.cpp.o -c ../../Tools/TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp
In file included from ../../Tools/TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:22:
../../Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:33:10: fatal error: wpe/webkit-web-extension.h: No such file or directory
   33 | #include <wpe/webkit-web-extension.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

The build failure started happening after a clean build.

This bot builds with `-DUSE_SOUP2=ON` thus ENABLE(2022_GLIB_API) is false but it seems webkit-web-extension.h is not generated.

[Diego Pino]

Re-opening for pull request https://github.com/webkit/webkit/pull/11276

[Michael Catanzaro]

In addition, I noticed that GTK 3 is now installing an unused (and unusable) webkit-web-process-extension.h, which is undesired.

[Michael Catanzaro]

Pull request: https://github.com/WebKit/WebKit/pull/11316

[EWS]

Committed 261474@main (94bb4c0cb7e9): <https://commits.webkit.org/261474@main>

Reviewed commits have been landed. Closing PR #11316 and removing active labels.