Bug 226642 - The CMake cache is removed when specifying a build target
Summary: The CMake cache is removed when specifying a build target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-04 06:12 PDT by Martin Robinson
Modified: 2021-06-04 10:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2021-06-04 06:13 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2021-06-04 06:35 PDT, Martin Robinson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2021-06-04 06:12:14 PDT 
When specifying a build target to build-webkit, for example running `build-webkit --gtk --release bin/MiniBrowser`, the addition of the build target causes build-webkit to delete the CMake cache. In this case, it really shouldn't be doing that. Only arguments which change the build configuration should trigger the removal of the cache.
Comment 1 Martin Robinson 2021-06-04 06:13:07 PDT 
Created attachment 430571 [details]
Patch
Comment 2 Martin Robinson 2021-06-04 06:35:45 PDT 
Created attachment 430572 [details]
Patch
Comment 3 EWS 2021-06-04 08:35:37 PDT 
Committed r278460 (238480@main): <https://commits.webkit.org/238480@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430572 [details].