Bug 226613 – [Cairo] Fix Path::boundingRectSlowCase when the path is a single MoveTo

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Arcady Goldmints-Orlov]

[Cairo] Fix Path::boundingRectSlowCase when the path is a single MoveTo

[Arcady Goldmints-Orlov]

Created attachment 430520 [details]
Patch

[Fujii Hironori]

I have questions.
Which benchmark are you using?
How does it improve?
Why is it using the single move paths?
Why is cairo_path_extents slower for the case?

[Fujii Hironori]

Oops. I misread and misunderstood.
This is not a speed-up, but a bug fix.
Do you have a test case?

[Carlos Garcia Campos]

Comment on attachment 430520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430520&action=review

> Source/WebCore/ChangeLog:7
> +

Could you explain here what's wrong exactly. Are we rendering anything incorrectly? does this fix any test? or can we add a new one?

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:414
> +    if (m_elements && m_elements.value().size() == 1
> +        && m_elements.value()[0].type == PathElement::Type::MoveToPoint) {

This could be a single line.

[Fujii Hironori]

Comment on attachment 430520 [details]
Patch

r- for comment#4.

[Arcady Goldmints-Orlov]

Sorry, I should have been clearer. This fixes the new fast/svg/bounding-rect-for-path-with-only-move-command.html test which was added recently, I will add that to the changelog, and fix the formatting issue. Thanks for taking a look.

[Arcady Goldmints-Orlov]

Created attachment 430981 [details]
Patch

[Arcady Goldmints-Orlov]

Created attachment 431000 [details]
Patch

[EWS]

Committed r278730 (238693@main): <https://commits.webkit.org/238693@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431000 [details].

[Radar WebKit Bug Importer]

<rdar://problem/79158727>