Bug 226604 - DFG should eliminate obvious store barriers
Summary: DFG should eliminate obvious store barriers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-03 15:01 PDT by Filip Pizlo
Modified: 2021-06-03 15:29 PDT (History)
7 users (show)

See Also:

Attachments
the patch (3.41 KB, patch)
2021-06-03 15:04 PDT, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2021-06-03 15:01:03 PDT 
We have a store barrier elimination strategy mostly based on "clustering" -- moving the barriers to the point where they will actually be meaningful.

Unfortunately, we have PutByOffset listed as DoesGC, so we will not eliminate any store barriers around sequences of PutByOffsets.  This appears to be the case because PutByOffset was accidentally added to the DoesGC list in r240991.
Comment 1 Filip Pizlo 2021-06-03 15:04:18 PDT 
Created attachment 430504 [details]
the patch
Comment 2 Mark Lam 2021-06-03 15:12:35 PDT 
Comment on attachment 430504 [details]
the patch

r=me
Comment 3 Filip Pizlo 2021-06-03 15:28:03 PDT 
Landed in https://trac.webkit.org/changeset/278424/webkit
Comment 4 Radar WebKit Bug Importer 2021-06-03 15:29:22 PDT 
<rdar://problem/78839959>