Bug 226598 - [MacOS & iOS] animations/leak-document-with-css-animation.html is a flaky failure
Summary: [MacOS & iOS] animations/leak-document-with-css-animation.html is a flaky fai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ayumi_kojima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-03 14:25 PDT by Amir Mark Jr
Modified: 2022-07-12 05:03 PDT (History)
10 users (show)

See Also:

Attachments
Update TestExpectations (1.60 KB, text/plain)
2021-07-12 16:19 PDT, ayumi_kojima 		no flags Details
Patch (1.49 KB, patch)
2021-07-12 16:41 PDT, ayumi_kojima 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amir Mark Jr 2021-06-03 14:25:26 PDT 
animations/leak-document-with-css-animation.html

Is a flaky failure on Big Sur E Wk1 Release and Catalina E WK2 Release


History:

https://results.webkit.org/?suite=layout-tests&test=animations%2Fleak-document-with-css-animation.html



Text Diff:

--- /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/animations/leak-document-with-css-animation-expected.txt
+++ /Volumes/Data/worker/bigsur-release-tests-wk1/build/layout-test-results/animations/leak-document-with-css-animation-actual.txt
@@ -5,7 +5,7 @@
 
 The iframe has finished loading.
 The iframe has been destroyed.
-PASS internals.numberOfLiveDocuments() is numberOfLiveDocumentsAfterIframeLoaded - 1
+FAIL internals.numberOfLiveDocuments() should be 16. Was 15.
 
 PASS successfullyParsed is true
Comment 1 Radar WebKit Bug Importer 2021-06-03 14:25:47 PDT 
<rdar://problem/78836186>
Comment 2 Amir Mark Jr 2021-06-03 16:22:15 PDT 
Updated test expectations:

https://trac.webkit.org/changeset/278427/webkit
Comment 3 Alexey Proskuryakov 2021-06-06 13:19:24 PDT 
This seems like a bad test that should be testing for "less than", not equality? Pre-existing documents can happen to get collected too.

We really need a better way to check for GC than looking at document counts.
Comment 4 ayumi_kojima 2021-07-12 16:13:34 PDT 
The failure is also seen on iOS 14 E Simulator Release. Couldn't reproduce the failure at tip of tree and a recent revision that shows a failure (r279826).

Tried: 
rwt animations/leak-document-with-css-animation.html --iterations 500 -f --ios-simulator
rwt animations/leak-document-with-css-animation.html --iterations 50 -f --child-process 20 --ios-simulator
rwt animations/leak-document-with-css-animation.html --iterations 50 -f --ios-simulator
Comment 5 ayumi_kojima 2021-07-12 16:13:53 PDT 
The flaky failure is also seen on iOS 14 E Simulator Release. Couldn't reproduce the failure at tip of tree and a recent revision that shows a failure (r279826).

Tried: 
rwt animations/leak-document-with-css-animation.html --iterations 500 -f --ios-simulator
rwt animations/leak-document-with-css-animation.html --iterations 50 -f --child-process 20 --ios-simulator
rwt animations/leak-document-with-css-animation.html --iterations 50 -f --ios-simulator
Comment 6 ayumi_kojima 2021-07-12 16:19:54 PDT 
Created attachment 433368 [details]
Update TestExpectations
Comment 7 Robert Jenner 2021-07-12 16:31:35 PDT 
Comment on attachment 433368 [details]
Update TestExpectations

Change where expectation is filed from platform/ios-simulator-wk2/TestExpectations.

to just platform/ios-wk2/TestExpectations.
Comment 8 ayumi_kojima 2021-07-12 16:41:09 PDT 
Created attachment 433371 [details]
Patch
Comment 9 Robert Jenner 2021-07-12 16:49:23 PDT 
Comment on attachment 433371 [details]
Patch

Clearing Flags on attachment: 433371

Committed r279857 (239611@main): <https://commits.webkit.org/239611@main>
Comment 10 Fujii Hironori 2022-07-12 05:03:05 PDT 
Fixed by 252375@main.