Bug 226596 - Stop storing Ref<IPC::Connection> in RTCDataChannelRemoteManagerProxy::m_webProcessConnections
Summary: Stop storing Ref<IPC::Connection> in RTCDataChannelRemoteManagerProxy::m_webP...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2021-06-03 13:38 PDT by Chris Dumez
Modified: 2021-06-03 14:35 PDT (History)
5 users (show)

See Also:

Patch (6.97 KB, patch)
2021-06-03 13:39 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-06-03 13:38:41 PDT
Stop storing Ref<IPC::Connection> in RTCDataChannelRemoteManagerProxy::m_webProcessConnections. Keeping the IPC::Connection alive always carries the chance of leaking if we fail to properly clear the HashMap. We can simply store an IPC::Connection::UniqueID and use that ID to send the IPC on the background thread.
Comment 1 Chris Dumez 2021-06-03 13:39:46 PDT
Created attachment 430496 [details]
Comment 2 EWS 2021-06-03 14:34:14 PDT
Committed r278420 (238444@main): <https://commits.webkit.org/238444@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430496 [details].
Comment 3 Radar WebKit Bug Importer 2021-06-03 14:35:21 PDT