Bug 226588 – [macOS] Image extraction preview panel should automatically close when the web view is unparented

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

rdar://77062762

[Wenson Hsieh]

Created attachment 430482 [details]
Patch

[Wenson Hsieh]

Created attachment 430486 [details]
Handle WP termination as well

[Tim Horton]

Comment on attachment 430486 [details]
Handle WP termination as well

View in context: https://bugs.webkit.org/attachment.cgi?id=430486&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2408
> +        m_page->closeSharedPreviewPanelIfNecessary();

maybe stick this right next to dismissContentRelativeChildWindowsWithAnimation above?

[Wenson Hsieh]

Thanks for the review!

(In reply to Tim Horton from comment #3)
> Comment on attachment 430486 [details]
> Handle WP termination as well
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430486&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2408
> > +        m_page->closeSharedPreviewPanelIfNecessary();
> 
> maybe stick this right next to
> dismissContentRelativeChildWindowsWithAnimation above?

Makes sense — moved to right after the `dismissContentRelativeChildWindowsWithAnimation(false);`.

[Wenson Hsieh]

Created attachment 430488 [details]
Patch

[EWS]

Committed r278414 (238439@main): <https://commits.webkit.org/238439@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430488 [details].