Bug 226588 - [macOS] Image extraction preview panel should automatically close when the web view is unparented
Summary: [macOS] Image extraction preview panel should automatically close when the we...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-03 10:28 PDT by Wenson Hsieh
Modified: 2021-06-03 16:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.59 KB, patch)
2021-06-03 10:51 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Handle WP termination as well (10.90 KB, patch)
2021-06-03 11:12 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (10.93 KB, patch)
2021-06-03 11:16 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-06-03 10:28:30 PDT 
rdar://77062762
Comment 1 Wenson Hsieh 2021-06-03 10:51:01 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-06-03 11:12:14 PDT 
Created attachment 430486 [details]
Handle WP termination as well
Comment 3 Tim Horton 2021-06-03 11:14:09 PDT 
Comment on attachment 430486 [details]
Handle WP termination as well

View in context: https://bugs.webkit.org/attachment.cgi?id=430486&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2408
> +        m_page->closeSharedPreviewPanelIfNecessary();

maybe stick this right next to dismissContentRelativeChildWindowsWithAnimation above?
Comment 4 Wenson Hsieh 2021-06-03 11:15:02 PDT 
Thanks for the review!

(In reply to Tim Horton from comment #3)
> Comment on attachment 430486 [details]
> Handle WP termination as well
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430486&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2408
> > +        m_page->closeSharedPreviewPanelIfNecessary();
> 
> maybe stick this right next to
> dismissContentRelativeChildWindowsWithAnimation above?

Makes sense — moved to right after the `dismissContentRelativeChildWindowsWithAnimation(false);`.
Comment 5 Wenson Hsieh 2021-06-03 11:16:31 PDT 
Created attachment 430488 [details]
Patch
Comment 6 EWS 2021-06-03 12:40:06 PDT 
Committed r278414 (238439@main): <https://commits.webkit.org/238439@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430488 [details].