Bug 226587 – Fix #include path for some Glib header files

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mohammad Imran]

Created attachment 430473 [details]
Patch file to update correct path for glib header files on WebKitGTK port

The following *.cpp files were using incorrect include path for their respective glib header files. This was causing missing header files errors while building WebkitGTK port on Ubuntu 20.04.

1. Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp - 
2. Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp
3. Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp

This patch include paths to use their correct <> path.

[Michael Catanzaro]

Comment on attachment 430473 [details]
Patch file to update correct path for glib header files on WebKitGTK port

I'm afraid you're going to have to investigate the CMake build system to see what include paths are missing and where. We don't use multi-level includes like this.

[Darryl Pogue]

Created attachment 430501 [details]
WebKit error build log

I'm also seeing this error with the header includes. I did a fresh clone of WebKit this morning and ran the following:

  Tools/gtk/install-dependencies
  Tools/Scripts/update-webkitgtk-libs
  Tools/Scripts/build-webkit --gtk --makeargs="-j2"

Build failure error log attached.

[Darryl Pogue]

This was fixed in https://commits.webkit.org/242819@main

[Michael Catanzaro]

Thanks for noticing.