Bug 226578 - Reintroduce logging useful for debugging in AudioSampleDataSource
Summary: Reintroduce logging useful for debugging in AudioSampleDataSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-03 06:25 PDT by youenn fablet
Modified: 2021-06-04 05:06 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.20 KB, patch)
2021-06-03 06:37 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-06-03 06:25:44 PDT 
Reintroduce logging useful for debugging in AudioSampleDataSource
Comment 1 youenn fablet 2021-06-03 06:37:22 PDT 
Created attachment 430465 [details]
Patch
Comment 2 youenn fablet 2021-06-03 11:08:33 PDT 
Comment on attachment 430465 [details]
Patch

I tried reducing the logging to the minimal case.
I guess we could try further optimisations so that callOnMainThread would not always trigger an allocation but I think this is fine without it.
Comment 3 EWS 2021-06-04 05:05:07 PDT 
Committed r278453 (238473@main): <https://commits.webkit.org/238473@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430465 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-04 05:06:16 PDT 
<rdar://problem/78864972>