Bug 226560 - Ensure run-safari keeps working
Summary: Ensure run-safari keeps working
Status: RESOLVED DUPLICATE of bug 189234
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-02 16:50 PDT by Sam Sneddon [:gsnedders]
Modified: 2022-11-14 03:31 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-06-02 16:50:23 PDT 
We have historically broken run-safari on a variety of occasions. We should either:

1. Push everyone towards run-minibrowser and drop run-safari, to avoid giving people the expectation it works.

2. Set up some form of testing automation to ensure run-safari remains functional.
Comment 1 Radar WebKit Bug Importer 2021-06-02 16:51:26 PDT 
<rdar://problem/78789239>
Comment 2 Alex Christensen 2021-06-02 18:28:05 PDT 
Last I heard our preferred solution for the overwhelming majority of these issues is rdar://74245355
Comment 3 Marcos Caceres 2021-06-03 21:12:30 PDT 
Breakages aside, the problem I ran into with Payment Request API is that minibrowser doesn't have - and probably never will have - ApplePay integration, which Safari does. So it was not possible for me to adequately test my patches. 

Having said that, Payment Request may be kinda unique in the way it interfaces with a system component. I'm not sure how many other APIs that do that, but it's something to consider if you go with option 1.
Comment 4 Sam Sneddon [:gsnedders] 2022-11-14 03:31:21 PST 

*** This bug has been marked as a duplicate of bug 189234 ***