RESOLVED FIXED226537
Drop Checked::safeGet() 
https://bugs.webkit.org/show_bug.cgi?id=226537
Summary Drop Checked::safeGet()
Chris Dumez
Reported 2021-06-02 08:13:55 PDT
Drop Checked::safeGet() and replace with uses of Checked::operator T() or Checked::value().
Attachments
Patch (20.81 KB, patch)
2021-06-02 08:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.00 KB, patch)
2021-06-02 08:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-02 08:16:30 PDT
Created attachment 430355 [details] Patch
Chris Dumez
Comment 2 2021-06-02 08:36:18 PDT
Created attachment 430361 [details] Patch
Geoffrey Garen
Comment 3 2021-06-02 11:04:33 PDT
Comment on attachment 430361 [details] Patch r=me
Darin Adler
Comment 4 2021-06-02 11:09:02 PDT
Looks good. In future code we write, I hope people will not need pairs of checked and unchecked local variables; just use Checked<> and it will typically do the right thing without naming everything xxxChecked. By the way, I think the syntax Checked<uint32_t> will be better than CheckedUint32 some day, so I hope we can later move to that. For now, I think moving to the aliases is better, but I don’t think we need modes other than RecordOverflow. Presumably the "crash right away when we overflow" mode is there for optimization reasons, but it seems unnecessary. Seems like it would always be fine to crash when you go to fetch the value rather than eagerly crashing while doing the math.
EWS
Comment 5 2021-06-02 12:02:24 PDT
Committed r278369 (238396@main): <https://commits.webkit.org/238396@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430361 [details].
Radar WebKit Bug Importer
Comment 6 2021-06-02 12:03:20 PDT
<rdar://problem/78776138>
Note You need to log in before you can comment on or make changes to this bug.