<rdar://59487603>
Created attachment 430307 [details] Patch
Will look into the EWS results whether they are actual failures.
Comment on attachment 430307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430307&action=review > Source/WebCore/rendering/RenderBlock.cpp:2260 > + if (is<RenderBlockFlow>(renderer)) > + logicalBottom += downcast<RenderBlockFlow>(renderer).lowestFloatLogicalBottom(); Since you will be blamed for this now, maybe look into the history of why it's this way, and add a FIXME if we think it's wrong. > Source/WebCore/rendering/RenderBlock.cpp:2264 > + if (pointInLogicalContents.y() > logicalBottomForCandidateBox || (!blocksAreFlipped && pointInLogicalContents.y() == logicalBottomForCandidateBox)) The `pointInLogicalContents.y() == logicalBottomForCandidateBox` test is very confusing here.
Created attachment 430433 [details] Patch
> View in context: > https://bugs.webkit.org/attachment.cgi?id=430307&action=review > > > Source/WebCore/rendering/RenderBlock.cpp:2260 > > + if (is<RenderBlockFlow>(renderer)) > > + logicalBottom += downcast<RenderBlockFlow>(renderer).lowestFloatLogicalBottom(); > > Since you will be blamed for this now, maybe look into the history of why > it's this way, and add a FIXME if we think it's wrong. > fixed in https://trac.webkit.org/changeset/278379/webkit
Comment on attachment 430433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430433&action=review > Source/WebCore/rendering/RenderBlock.cpp:2188 > + if (isTable() || isFlexibleBoxIncludingDeprecated() || isRenderGrid()) Should you add grid and deprecated flex box tests?
Created attachment 430478 [details] Patch
Created attachment 430481 [details] [fast-cq] Patch
Committed r278411 (238436@main): <https://commits.webkit.org/238436@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430481 [details].
<rdar://problem/78825560>