Bug 226511 - Add log when creating NSURLSession that will not accept cookies
Summary: Add log when creating NSURLSession that will not accept cookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-01 13:24 PDT by Alex Christensen
Modified: 2021-06-21 11:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2021-06-01 13:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.15 KB, patch)
2021-06-01 13:32 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.16 KB, patch)
2021-06-01 15:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2021-06-21 11:33 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-06-01 13:24:43 PDT 
Add log when creating NSURLSession that will not accept cookies
Comment 1 Alex Christensen 2021-06-01 13:25:04 PDT 
Created attachment 430285 [details]
Patch
Comment 2 Alex Christensen 2021-06-01 13:25:07 PDT 
<rdar://problem/77637158>
Comment 3 Chris Dumez 2021-06-01 13:26:41 PDT 
Comment on attachment 430285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430285&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310
> +        RELEASE_LOG_INFO(NetworkSession, "Creating network session that will not accept cookies.");

Why RELEASE_LOG_INFO() and not a simple RELEASE_LOG()? Also, shouldn't this print the sessionID (or some kind of ID so we can identify the session)?
Comment 4 Alex Christensen 2021-06-01 13:32:25 PDT 
Created attachment 430288 [details]
Patch
Comment 5 Chris Dumez 2021-06-01 14:36:27 PDT 
Comment on attachment 430288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430288&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310
> +        RELEASE_LOG(NetworkSession, "Creating network session with ID %llu that will not accept cookies.", m_sessionID.toUInt64());

We should probably use PRIu64 even if this is a cocoa file.
Comment 6 Alex Christensen 2021-06-01 15:54:47 PDT 
Created attachment 430301 [details]
Patch
Comment 7 youenn fablet 2021-06-02 07:12:35 PDT 
Comment on attachment 430301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430301&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310
> +        RELEASE_LOG(NetworkSession, "Creating network session with ID %" PRIu64 " that will not accept cookies.", m_sessionID.toUInt64());

RELEASE_LOG_IF?
Comment 8 Alex Christensen 2021-06-21 11:33:47 PDT 
Created attachment 431885 [details]
Patch
Comment 9 Alex Christensen 2021-06-21 11:44:24 PDT 
http://trac.webkit.org/r279071