Bug 226511 – Add log when creating NSURLSession that will not accept cookies

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Add log when creating NSURLSession that will not accept cookies

[Alex Christensen]

Created attachment 430285 [details]
Patch

[Alex Christensen]

<rdar://problem/77637158>

[Chris Dumez]

Comment on attachment 430285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430285&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310
> +        RELEASE_LOG_INFO(NetworkSession, "Creating network session that will not accept cookies.");

Why RELEASE_LOG_INFO() and not a simple RELEASE_LOG()? Also, shouldn't this print the sessionID (or some kind of ID so we can identify the session)?

[Alex Christensen]

Created attachment 430288 [details]
Patch

[Chris Dumez]

Comment on attachment 430288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430288&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310
> +        RELEASE_LOG(NetworkSession, "Creating network session with ID %llu that will not accept cookies.", m_sessionID.toUInt64());

We should probably use PRIu64 even if this is a cocoa file.

[Alex Christensen]

Created attachment 430301 [details]
Patch

[youenn fablet]

Comment on attachment 430301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430301&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1310
> +        RELEASE_LOG(NetworkSession, "Creating network session with ID %" PRIu64 " that will not accept cookies.", m_sessionID.toUInt64());

RELEASE_LOG_IF?

[Alex Christensen]

Created attachment 431885 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r279071