Bug 226508 - Fix unsafe access to m_upload in XMLHttpRequest::virtualHasPendingActivity()
Summary: Fix unsafe access to m_upload in XMLHttpRequest::virtualHasPendingActivity()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-01 12:51 PDT by Chris Dumez
Modified: 2021-06-01 15:04 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.92 KB, patch)
2021-06-01 12:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-06-01 12:51:57 PDT 
Fix unsafe access to m_upload in XMLHttpRequest::virtualHasPendingActivity() as virtualHasPendingActivity() may get called off the main thread and m_upload gets initialized lazily on the main thread.
Comment 1 Chris Dumez 2021-06-01 12:54:35 PDT 
Created attachment 430282 [details]
Patch
Comment 2 Geoffrey Garen 2021-06-01 13:19:58 PDT 
Comment on attachment 430282 [details]
Patch

r=me
Comment 3 EWS 2021-06-01 15:03:42 PDT 
Committed r278329 (238362@main): <https://commits.webkit.org/238362@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430282 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-01 15:04:18 PDT 
<rdar://problem/78734398>