Bug 226507 - [macOS] Data detector highlights should appear when hovering inside image overlays
Summary: [macOS] Data detector highlights should appear when hovering inside image ove...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-01 12:50 PDT by Wenson Hsieh
Modified: 2021-06-01 15:38 PDT (History)
9 users (show)

See Also:


Attachments
Patch (17.80 KB, patch)
2021-06-01 13:30 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (17.79 KB, patch)
2021-06-01 14:02 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-06-01 12:50:39 PDT
.
Comment 1 Wenson Hsieh 2021-06-01 13:30:30 PDT
Created attachment 430287 [details]
Patch
Comment 2 Tim Horton 2021-06-01 13:59:05 PDT
Comment on attachment 430287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430287&action=review

> Source/WebCore/ChangeLog:10
> +        allow the ImageOverlayController install its page overlay when the element under the mouse is inside an image

"allow the ImageOverlayController install" grammar-o
Comment 3 Wenson Hsieh 2021-06-01 14:00:22 PDT
Comment on attachment 430287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430287&action=review

Thanks for the review!

>> Source/WebCore/ChangeLog:10
>> +        allow the ImageOverlayController install its page overlay when the element under the mouse is inside an image
> 
> "allow the ImageOverlayController install" grammar-o

(Whoops.)
Comment 4 Wenson Hsieh 2021-06-01 14:02:46 PDT
Created attachment 430289 [details]
Patch
Comment 5 EWS 2021-06-01 15:37:04 PDT
Committed r278331 (238364@main): <https://commits.webkit.org/238364@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430289 [details].
Comment 6 Radar WebKit Bug Importer 2021-06-01 15:38:18 PDT
<rdar://problem/78735990>