Bug 226498 - [EME][Thunder] Build broken since r278244
Summary: [EME][Thunder] Build broken since r278244
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
Depends on:
Reported: 2021-06-01 07:53 PDT by Philippe Normand
Modified: 2021-06-01 13:23 PDT (History)
9 users (show)

See Also:

Patch (1.47 KB, patch)
2021-06-01 07:55 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-06-01 07:53:14 PDT
../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:678:12: error: cannot cast from type 'const WeakPtr<WebCore::CDMInstanceProxy>' to pointer type 'WebCore::CDMInstanceThunder *'
    return static_cast<CDMInstanceThunder*>(cdmInstanceProxy());
1 error generated.
Comment 1 Philippe Normand 2021-06-01 07:55:41 PDT
Created attachment 430262 [details]
Comment 2 EWS 2021-06-01 11:50:23 PDT
Committed r278316 (238352@main): <https://commits.webkit.org/238352@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430262 [details].
Comment 3 Radar WebKit Bug Importer 2021-06-01 11:51:21 PDT
Comment 4 Darin Adler 2021-06-01 13:23:07 PDT
Comment on attachment 430262 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=430262&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:679
> -    return static_cast<CDMInstanceThunder*>(cdmInstanceProxy());
> +    auto proxy = cdmInstanceProxy();
> +    return static_cast<CDMInstanceThunder*>(proxy.get());

Adding the ".get()" was good. But adding the local variable was unnecessary.