Bug 226460 - MediaSessionCoordinator API test is failing,
Summary: MediaSessionCoordinator API test is failing,
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar, Regression
: 226459 (view as bug list)
Depends on: 226328
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-31 01:26 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-06-02 10:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2021-06-02 01:14 PDT, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-05-31 01:26:13 PDT 
The test TestWebKitAPI.MediaSessionCoordinatorTest.StateChanges fails with the error:
```
       /Users/jyavenard/Work/webkit/OpenSource/Tools/TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm:468
        Expected equality of these values:
          "coordinatorStateChanged"
          lastStateChange.utf8().data()
            Which is: ""
        
```

This is a regression from bug 225822.

the test expects that there will be a callback to coordinatorStateChange when MediaSessionCoordinatorPrivate::leave() is called which is no longer the case.
Comment 1 Radar WebKit Bug Importer 2021-05-31 01:26:36 PDT 
<rdar://problem/78680005>
Comment 2 youenn fablet 2021-06-01 04:36:02 PDT 
*** Bug 226459 has been marked as a duplicate of this bug. ***
Comment 3 Jean-Yves Avenard [:jya] 2021-06-02 01:14:38 PDT 
Created attachment 430324 [details]
Patch
Comment 4 Eric Carlson 2021-06-02 09:43:31 PDT 
Comment on attachment 430324 [details]
Patch

Windows failure is unrelated.
Comment 5 EWS 2021-06-02 10:07:10 PDT 
Committed r278363 (238393@main): <https://commits.webkit.org/238393@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430324 [details].