Bug 226453 – add Internals method to expose synchronous scrolling reasons for individual scrolling tree scrolling nodes

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Scrolling

[Cameron McCormack (:heycam)]

So we can test the synchronous scrolling reasons are set correctly on scrolling tree nodes for overflow:scroll elements.

[Cameron McCormack (:heycam)]

Created attachment 430174 [details]
Patch

[Frédéric Wang (:fredw)]

Comment on attachment 430174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430174&action=review

> Source/WebCore/testing/Internals.h:441
> +    ExceptionOr<String> synchronousScrollingReasonsForScrollableElement(Element&) const;

Is it possible to make this a const Element&?

[Simon Fraser (smfr)]

Doesn't dumping the scrolling state tree suffice?

[Cameron McCormack (:heycam)]

(In reply to Simon Fraser (smfr) from comment #3)
> Doesn't dumping the scrolling state tree suffice?

As I discovered from looking at other tests, yes it does.  But it includes a lot of other irrelevant information for my tests.  Seems like it's better to avoid having to update test expectations for changes in other parts of the scrolling state tree, but if you think it's better to just use the existing thing and avoid adding something new, I can do that.

[Darin Adler]

Comment on attachment 430174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430174&action=review

>> Source/WebCore/testing/Internals.h:441
>> +    ExceptionOr<String> synchronousScrollingReasonsForScrollableElement(Element&) const;
> 
> Is it possible to make this a const Element&?

Why does that matter? This is designed to be called from JavaScript.

[Cameron McCormack (:heycam)]

(In reply to Simon Fraser (smfr) from comment #3)
> Doesn't dumping the scrolling state tree suffice?

I've updated my tests in bug 226399 to use the scrolling state tree dump so I'm not going to use this patch.