Bug 226445 - Drop PendingActivity data member from BaseAudioContext
Summary: Drop PendingActivity data member from BaseAudioContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-30 19:25 PDT by Chris Dumez
Modified: 2021-05-31 17:09 PDT (History)
12 users (show)

See Also:

Attachments
Patch (10.19 KB, patch)
2021-05-30 19:27 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (10.18 KB, patch)
2021-05-30 19:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-30 19:25:36 PDT 
Drop PendingActivity data member from BaseAudioContext and instead have AudioContext / OfflineAudioContext override virtualHasPendingActivity() to keep their JS wrapper alive. I find that PendingActivity data members are too error prone and a frequent cause of leaks.
Comment 1 Chris Dumez 2021-05-30 19:27:28 PDT 
Created attachment 430163 [details]
Patch
Comment 2 Chris Dumez 2021-05-30 19:29:03 PDT 
Created attachment 430164 [details]
Patch
Comment 3 EWS 2021-05-31 17:08:27 PDT 
Committed r278288 (238325@main): <https://commits.webkit.org/238325@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430164 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-31 17:09:17 PDT 
<rdar://problem/78695343>