Bug 226435 - [LFC] Tighten the constraint classes (ConstraintsForInFlowContent/ConstraintsForOutOfFlowContent)
Summary: [LFC] Tighten the constraint classes (ConstraintsForInFlowContent/Constraints...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-30 06:57 PDT by zalan
Modified: 2021-05-31 19:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (30.41 KB, patch)
2021-05-30 07:07 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (59.10 KB, patch)
2021-05-31 16:54 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (67.08 KB, patch)
2021-05-31 17:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq] Patch (66.09 KB, patch)
2021-05-31 19:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-05-30 06:57:58 PDT 
ssia
Comment 1 zalan 2021-05-30 07:07:00 PDT 
Created attachment 430134 [details]
Patch
Comment 2 Antti Koivisto 2021-05-31 07:38:59 PDT 
Comment on attachment 430134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430134&action=review

> Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp:59
> +    auto availableVerticalSpace = ((const ConstraintsForTableContent&)constraints).availableVerticalSpaceForContent;

What's up with the C cast here?
Comment 3 zalan 2021-05-31 16:54:00 PDT 
Created attachment 430216 [details]
Patch
Comment 4 zalan 2021-05-31 17:00:59 PDT 
Created attachment 430217 [details]
Patch
Comment 5 EWS 2021-05-31 19:16:33 PDT 
Tools/Scripts/svn-apply failed to apply attachment 430217 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 zalan 2021-05-31 19:26:24 PDT 
Created attachment 430224 [details]
[fast-cq] Patch
Comment 7 EWS 2021-05-31 19:41:08 PDT 
Committed r278292 (238329@main): <https://commits.webkit.org/238329@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430224 [details].
Comment 8 Radar WebKit Bug Importer 2021-05-31 19:42:16 PDT 
<rdar://problem/78697838>