Bug 226431 - Adopt clang thread safety annotations in WTF::DataMutex
Summary: Adopt clang thread safety annotations in WTF::DataMutex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 226432
  Show dependency tree / graph
 
Reported: 2021-05-29 20:01 PDT by Chris Dumez
Modified: 2021-06-03 04:03 PDT (History)
21 users (show)

See Also:

Attachments
Patch (34.16 KB, patch)
2021-05-29 20:03 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (34.89 KB, patch)
2021-05-29 20:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.93 KB, patch)
2021-05-29 20:16 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (38.05 KB, patch)
2021-05-29 20:20 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (37.97 KB, patch)
2021-05-29 20:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-29 20:01:42 PDT 
Adopt clang thread safety annotation in WTF::DataMutex. This allows us to stop using UncheckedCondition in a few places.
Comment 1 Chris Dumez 2021-05-29 20:03:58 PDT 
Created attachment 430122 [details]
Patch
Comment 2 Chris Dumez 2021-05-29 20:05:48 PDT 
Created attachment 430123 [details]
Patch
Comment 3 Chris Dumez 2021-05-29 20:16:47 PDT 
Created attachment 430124 [details]
Patch
Comment 4 Chris Dumez 2021-05-29 20:20:02 PDT 
Created attachment 430125 [details]
Patch
Comment 5 Chris Dumez 2021-05-29 20:26:57 PDT 
Created attachment 430126 [details]
Patch
Comment 6 EWS 2021-05-29 22:23:05 PDT 
Committed r278248 (238285@main): <https://commits.webkit.org/238285@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430126 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-29 22:24:22 PDT 
<rdar://problem/78656465>
Comment 8 Alicia Boya García 2021-06-03 04:03:48 PDT 
Comment on attachment 430126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430126&action=review

> Source/WTF/wtf/DataMutex.h:68
> +        DATA_MUTEX_CHECK(!mutex().isHeld());

Checking this *before* taking the mutex will crash in inocuous cases such when another thread has already locked the DataMutex and the calling thread needs to wait.