Bug 226428 – Stop using UncheckedLock in JSC::ConcurrentJSLock

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Chris Dumez]

Stop using UncheckedLock in JSC::ConcurrentJSLock as it is being phased out in favor of Lock, which supports Clang thread safety analysis.

[Chris Dumez]

Created attachment 430118 [details]
Patch

[EWS]

Committed r278249 (238286@main): <https://commits.webkit.org/238286@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430118 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78656527>

[Darin Adler]

Comment on attachment 430118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430118&action=review

> Source/JavaScriptCore/runtime/ConcurrentJSLock.h:68
> +    Optional<ConcurrentJSLockerImpl> m_locker;

I should have remembered to ask you to use std::optional<> here. Optional<> is a deprecated synonym.

[Chris Dumez]

(In reply to Darin Adler from comment #4)
> Comment on attachment 430118 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430118&action=review
> 
> > Source/JavaScriptCore/runtime/ConcurrentJSLock.h:68
> > +    Optional<ConcurrentJSLockerImpl> m_locker;
> 
> I should have remembered to ask you to use std::optional<> here. Optional<>
> is a deprecated synonym.

Old habits die hard, sorry :/