Bug 226428 - Stop using UncheckedLock in JSC::ConcurrentJSLock
Summary: Stop using UncheckedLock in JSC::ConcurrentJSLock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 226432
  Show dependency tree / graph
 
Reported: 2021-05-29 17:37 PDT by Chris Dumez
Modified: 2021-05-29 23:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.83 KB, patch)
2021-05-29 17:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-29 17:37:37 PDT 
Stop using UncheckedLock in JSC::ConcurrentJSLock as it is being phased out in favor of Lock, which supports Clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-29 17:39:01 PDT 
Created attachment 430118 [details]
Patch
Comment 2 EWS 2021-05-29 22:36:05 PDT 
Committed r278249 (238286@main): <https://commits.webkit.org/238286@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430118 [details].
Comment 3 Radar WebKit Bug Importer 2021-05-29 22:37:21 PDT 
<rdar://problem/78656527>
Comment 4 Darin Adler 2021-05-29 23:08:55 PDT 
Comment on attachment 430118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430118&action=review

> Source/JavaScriptCore/runtime/ConcurrentJSLock.h:68
> +    Optional<ConcurrentJSLockerImpl> m_locker;

I should have remembered to ask you to use std::optional<> here. Optional<> is a deprecated synonym.
Comment 5 Chris Dumez 2021-05-29 23:11:36 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 430118 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430118&action=review
> 
> > Source/JavaScriptCore/runtime/ConcurrentJSLock.h:68
> > +    Optional<ConcurrentJSLockerImpl> m_locker;
> 
> I should have remembered to ask you to use std::optional<> here. Optional<>
> is a deprecated synonym.

Old habits die hard, sorry :/