Bug 226427 - Stop using UncheckedLock in JSC::VMInspector
Summary: Stop using UncheckedLock in JSC::VMInspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 226432
  Show dependency tree / graph
 
Reported: 2021-05-29 16:31 PDT by Chris Dumez
Modified: 2021-05-29 23:53 PDT (History)
12 users (show)

See Also:

Attachments
Patch (11.87 KB, patch)
2021-05-29 16:51 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (11.88 KB, patch)
2021-05-29 17:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (12.47 KB, patch)
2021-05-29 22:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-29 16:31:03 PDT 
Stop using UncheckedLock in JSC::VMInspector, as it is being phased out in favor of Lock, which supports Clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-29 16:51:13 PDT 
Created attachment 430115 [details]
Patch
Comment 2 Chris Dumez 2021-05-29 17:06:09 PDT 
Created attachment 430117 [details]
Patch
Comment 3 Mark Lam 2021-05-29 21:49:55 PDT 
Comment on attachment 430117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430117&action=review

r=me

> Source/WTF/wtf/Lock.cpp:35
> +#include <unistd.h>

Is the #include in VMInspector.cpp still needed?  If not, can you remove it?
Comment 4 Chris Dumez 2021-05-29 22:24:35 PDT 
Created attachment 430129 [details]
Patch
Comment 5 Chris Dumez 2021-05-29 22:24:55 PDT 
(In reply to Mark Lam from comment #3)
> Comment on attachment 430117 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430117&action=review
> 
> r=me
> 
> > Source/WTF/wtf/Lock.cpp:35
> > +#include <unistd.h>
> 
> Is the #include in VMInspector.cpp still needed?  If not, can you remove it?

Done.
Comment 6 EWS 2021-05-29 23:52:04 PDT 
Committed r278251 (238288@main): <https://commits.webkit.org/238288@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430129 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-29 23:53:20 PDT 
<rdar://problem/78657229>