RESOLVED FIXED 226427
Stop using UncheckedLock in JSC::VMInspector 
https://bugs.webkit.org/show_bug.cgi?id=226427
Summary Stop using UncheckedLock in JSC::VMInspector
Chris Dumez
Reported 2021-05-29 16:31:03 PDT
Stop using UncheckedLock in JSC::VMInspector, as it is being phased out in favor of Lock, which supports Clang thread safety analysis.
Attachments
Patch (11.87 KB, patch)
2021-05-29 16:51 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (11.88 KB, patch)
2021-05-29 17:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (12.47 KB, patch)
2021-05-29 22:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-29 16:51:13 PDT
Created attachment 430115 [details] Patch
Chris Dumez
Comment 2 2021-05-29 17:06:09 PDT
Created attachment 430117 [details] Patch
Mark Lam
Comment 3 2021-05-29 21:49:55 PDT
Comment on attachment 430117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430117&action=review r=me > Source/WTF/wtf/Lock.cpp:35 > +#include <unistd.h> Is the #include in VMInspector.cpp still needed? If not, can you remove it?
Chris Dumez
Comment 4 2021-05-29 22:24:35 PDT
Created attachment 430129 [details] Patch
Chris Dumez
Comment 5 2021-05-29 22:24:55 PDT
(In reply to Mark Lam from comment #3) > Comment on attachment 430117 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430117&action=review > > r=me > > > Source/WTF/wtf/Lock.cpp:35 > > +#include <unistd.h> > > Is the #include in VMInspector.cpp still needed? If not, can you remove it? Done.
EWS
Comment 6 2021-05-29 23:52:04 PDT
Committed r278251 (238288@main): <https://commits.webkit.org/238288@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430129 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-29 23:53:20 PDT
<rdar://problem/78657229>
Note You need to log in before you can comment on or make changes to this bug.