Bug 226411 – Web process terminates when attempting to log in on bankid.no

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Wenson Hsieh]

rdar://77419432

[Wenson Hsieh]

Created attachment 430082 [details]
For EWS

[Chris Dumez]

Comment on attachment 430082 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=430082&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.h:60
> +    WEBCORE_EXPORT Replayer(GraphicsContext&, const DisplayList&, const ImageBufferHashMap* = nullptr, const NativeImageHashMap* = nullptr, const FontRenderingResourceMap* = nullptr, WebCore::ImageBuffer* maskImageBuffer = { }, Delegate* = nullptr);

nit: = nullptr would look clearer IMO.

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:501
> +    m_currentMaskImageBuffer = makeRefPtr(imageBuffer);

m_currentMaskImageBuffer = &imageBuffer;

should work

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:87
> +    void didCreateMaskImageBuffer(WebCore::ImageBuffer&);

Shouldn't this be marked as final / override?

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:88
> +    void didResetMaskImageBuffer();

ditto.

[Wenson Hsieh]

Comment on attachment 430082 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=430082&action=review

>> Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.h:60
>> +    WEBCORE_EXPORT Replayer(GraphicsContext&, const DisplayList&, const ImageBufferHashMap* = nullptr, const NativeImageHashMap* = nullptr, const FontRenderingResourceMap* = nullptr, WebCore::ImageBuffer* maskImageBuffer = { }, Delegate* = nullptr);
> 
> nit: = nullptr would look clearer IMO.

Good point. Changed to `nullptr`.

>> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:501
>> +    m_currentMaskImageBuffer = makeRefPtr(imageBuffer);
> 
> m_currentMaskImageBuffer = &imageBuffer;
> 
> should work

Changed to `m_currentMaskImageBuffer = &imageBuffer;`!

>> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:87
>> +    void didCreateMaskImageBuffer(WebCore::ImageBuffer&);
> 
> Shouldn't this be marked as final / override?

Ah, so these are just methods on RemoteRenderingBackend; the overridden methdos are in `RemoteImageBuffer`, where they are marked as `final`.

(The RemoteImageBuffer methods are just plumbing directly into `RemoteRenderingBackend`)

[Wenson Hsieh]

Created attachment 430086 [details]
Patch

[Wenson Hsieh]

Comment on attachment 430086 [details]
Patch

Thank you for the review!

[EWS]

Committed r278235 (238272@main): <https://commits.webkit.org/238272@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430086 [details].