Bug 226396 - Stop using UncheckedLock in WTF::MetaAllocator
Summary: Stop using UncheckedLock in WTF::MetaAllocator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-28 14:36 PDT by Chris Dumez
Modified: 2021-05-28 18:07 PDT (History)
14 users (show)

See Also:

Attachments
Patch (10.39 KB, patch)
2021-05-28 14:37 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2021-05-28 14:52 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.22 KB, patch)
2021-05-28 17:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-28 14:36:46 PDT 
Stop using UncheckedLock in WTF::MetaAllocator, as it is being phased out in favor on Lock, which supports Clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-28 14:37:55 PDT 
Created attachment 430053 [details]
Patch
Comment 2 Chris Dumez 2021-05-28 14:52:29 PDT 
Created attachment 430060 [details]
Patch
Comment 3 Darin Adler 2021-05-28 16:28:37 PDT 
Comment on attachment 430060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430060&action=review

> Source/JavaScriptCore/tools/VMInspector.cpp:131
> +        WTF::Locker executableAllocatorLocker { lock };

The usual "using WTF" trick doesn’t work here?
Comment 4 Chris Dumez 2021-05-28 16:30:11 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 430060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430060&action=review
> 
> > Source/JavaScriptCore/tools/VMInspector.cpp:131
> > +        WTF::Locker executableAllocatorLocker { lock };
> 
> The usual "using WTF" trick doesn’t work here?

The issue is that VMInspector has a using `Locker = Locker<UncheckedLock>`. I will look into removing it.
Comment 5 Chris Dumez 2021-05-28 17:02:36 PDT 
Created attachment 430075 [details]
Patch
Comment 6 EWS 2021-05-28 18:06:02 PDT 
Committed r278232 (238269@main): <https://commits.webkit.org/238269@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430075 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-28 18:07:24 PDT 
<rdar://problem/78639206>