Bug 226396 – Stop using UncheckedLock in WTF::MetaAllocator

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Chris Dumez]

Stop using UncheckedLock in WTF::MetaAllocator, as it is being phased out in favor on Lock, which supports Clang thread safety analysis.

[Chris Dumez]

Created attachment 430053 [details]
Patch

[Chris Dumez]

Created attachment 430060 [details]
Patch

[Darin Adler]

Comment on attachment 430060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430060&action=review

> Source/JavaScriptCore/tools/VMInspector.cpp:131
> +        WTF::Locker executableAllocatorLocker { lock };

The usual "using WTF" trick doesn’t work here?

[Chris Dumez]

(In reply to Darin Adler from comment #3)
> Comment on attachment 430060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430060&action=review
> 
> > Source/JavaScriptCore/tools/VMInspector.cpp:131
> > +        WTF::Locker executableAllocatorLocker { lock };
> 
> The usual "using WTF" trick doesn’t work here?

The issue is that VMInspector has a using `Locker = Locker<UncheckedLock>`. I will look into removing it.

[Chris Dumez]

Created attachment 430075 [details]
Patch

[EWS]

Committed r278232 (238269@main): <https://commits.webkit.org/238269@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430075 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78639206>