Bug 226381 - Regenerate builtins generator expectations after optional changes
Summary: Regenerate builtins generator expectations after optional changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-28 10:16 PDT by Stephan Szabo
Modified: 2021-05-28 13:21 PDT (History)
9 users (show)

See Also:

Attachments
Patch (17.09 KB, patch)
2021-05-28 10:19 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-05-28 10:16:40 PDT 
After changing WTF::nullopt -> std::nullopt, regenerate expectations
Comment 1 Stephan Szabo 2021-05-28 10:19:22 PDT 
Created attachment 430024 [details]
Patch
Comment 2 Chris Dumez 2021-05-28 10:22:13 PDT 
Comment on attachment 430024 [details]
Patch

r=me
Comment 3 EWS 2021-05-28 11:11:40 PDT 
Committed r278210 (238253@main): <https://commits.webkit.org/238253@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430024 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-28 11:12:20 PDT 
<rdar://problem/78625210>
Comment 5 Darin Adler 2021-05-28 13:21:05 PDT 
Thank you; very sorry I overlooked this. Should we add something to the style checker to remind people to do this in future? I think that exists for some other similar cases.