WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226381
Regenerate builtins generator expectations after optional changes
https://bugs.webkit.org/show_bug.cgi?id=226381
Summary
Regenerate builtins generator expectations after optional changes
Stephan Szabo
Reported
2021-05-28 10:16:40 PDT
After changing WTF::nullopt -> std::nullopt, regenerate expectations
Attachments
Patch
(17.09 KB, patch)
2021-05-28 10:19 PDT
,
Stephan Szabo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Stephan Szabo
Comment 1
2021-05-28 10:19:22 PDT
Created
attachment 430024
[details]
Patch
Chris Dumez
Comment 2
2021-05-28 10:22:13 PDT
Comment on
attachment 430024
[details]
Patch r=me
EWS
Comment 3
2021-05-28 11:11:40 PDT
Committed
r278210
(
238253@main
): <
https://commits.webkit.org/238253@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 430024
[details]
.
Radar WebKit Bug Importer
Comment 4
2021-05-28 11:12:20 PDT
<
rdar://problem/78625210
>
Darin Adler
Comment 5
2021-05-28 13:21:05 PDT
Thank you; very sorry I overlooked this. Should we add something to the style checker to remind people to do this in future? I think that exists for some other similar cases.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug