Bug 22638 - Add POST method support to WML <go> element
Summary: Add POST method support to WML <go> element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on: 22949
Blocks: 20393
  Show dependency treegraph
 
Reported: 2008-12-03 16:19 PST by Nikolas Zimmermann
Modified: 2008-12-21 18:05 PST (History)
0 users

See Also:


Attachments
Initial patch (10.21 KB, patch)
2008-12-20 17:26 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Layout test results (23.09 KB, patch)
2008-12-20 17:26 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Updated patch (10.42 KB, patch)
2008-12-21 17:50 PST, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff
Updated layout test results (22.87 KB, patch)
2008-12-21 17:51 PST, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff
WebKitTools changes (1.62 KB, patch)
2008-12-21 18:02 PST, Nikolas Zimmermann
staikos: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2008-12-03 16:19:24 PST
Add POST method support to WML <go> element.
Comment 1 Nikolas Zimmermann 2008-12-20 17:26:19 PST
Created attachment 26174 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2008-12-20 17:26:41 PST
Created attachment 26175 [details]
Layout test results
Comment 3 Nikolas Zimmermann 2008-12-20 18:49:11 PST
Comment on attachment 26174 [details]
Initial patch

Clearing review flag for now. As suggested by Holger, a better approach would be to create a FormDataBuilder class, which encapsulates the Vector<char> instead of having to pass it to several functions, as it is in this patch. Uploading a revised version soon - see bug 22949.
Comment 4 Nikolas Zimmermann 2008-12-21 17:50:58 PST
Created attachment 26193 [details]
Updated patch
Comment 5 Nikolas Zimmermann 2008-12-21 17:51:26 PST
Created attachment 26194 [details]
Updated layout test results
Comment 6 Nikolas Zimmermann 2008-12-21 17:52:33 PST
Adapted to changes in bug 22949 - helper class is now called 'FormDataBuilder', not 'FormElementData'.
Comment 7 Nikolas Zimmermann 2008-12-21 18:02:10 PST
Created attachment 26195 [details]
WebKitTools changes
Comment 8 Nikolas Zimmermann 2008-12-21 18:05:56 PST
Landed in r39431.