<rdar://78298472>
Created attachment 430007 [details] Patch
Comment on attachment 430007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430007&action=review > Source/WebCore/testing/ServiceWorkerInternals.cpp:63 > + if (!result.has_value()) { It looks like this whole change could just be a value_or({ })
Comment on attachment 430007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430007&action=review > Source/WebCore/testing/ServiceWorkerInternals.cpp:67 > + auto& error = result.error(); > + String description; > + if (error) > + description = error->localizedDescription(); Nice way to write this: String description; if (auto& error = result.error()) description = error->localizedDescription();
Created attachment 430182 [details] Patch for landing
(In reply to Darin Adler from comment #3) > Comment on attachment 430007 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430007&action=review > > > Source/WebCore/testing/ServiceWorkerInternals.cpp:67 > > + auto& error = result.error(); > > + String description; > > + if (error) > > + description = error->localizedDescription(); > > Nice way to write this: > > String description; > if (auto& error = result.error()) > description = error->localizedDescription(); Done
Committed r278274 (238311@main): <https://commits.webkit.org/238311@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430182 [details].