[WPE] Correctly compute wheel event phase for 2D axis events
Created attachment 429999 [details] Patch
Comment on attachment 429999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429999&action=review > Source/WebKit/UIProcess/API/wpe/WPEView.cpp:177 > +#if WPE_CHECK_VERSION(1, 5, 0) Would it make sense to remove the check and require libwpe 1.6.0+ unconditionally? Version 1.6.0 is a bit over a year old, so when WPE WebKit 2.34.0 hits the shelves by then it would be 1.5 years. I have no strong preference yet about whether to keep this one check or not, I only wanted to raise the question :)
Comment on attachment 429999 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429999&action=review >> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:177 >> +#if WPE_CHECK_VERSION(1, 5, 0) > > Would it make sense to remove the check and require libwpe 1.6.0+ unconditionally? > Version 1.6.0 is a bit over a year old, so when WPE WebKit 2.34.0 hits the shelves > by then it would be 1.5 years. > > I have no strong preference yet about whether to keep this one check or not, I only > wanted to raise the question :) This patch has to go into the 2.32 branch as-is. Decisions about minimum deps and when to remove these guards can wait for at least three more months.
zan@falconsigh.net does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 429999 [details] from commit queue.
Committed r278198 (238241@main): <https://commits.webkit.org/238241@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429999 [details].
<rdar://problem/78619944>