Bug 226366 - Add 'mix' override with bool-vectors to MSL translator
Summary: Add 'mix' override with bool-vectors to MSL translator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-27 21:08 PDT by Kyle Piddington
Modified: 2021-06-02 10:02 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.65 KB, patch)
2021-05-27 21:11 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (9.67 KB, patch)
2021-05-28 10:49 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-05-27 21:08:30 PDT 
The GLSL function 'mix' includes several overrides that take a bool vector. However, MSL does not natively support this.
Add in functionality and a test to support mix with bool
Comment 1 Kyle Piddington 2021-05-27 21:11:18 PDT 
Created attachment 429981 [details]
Patch
Comment 2 EWS Watchlist 2021-05-27 21:12:15 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kimmo Kinnunen 2021-05-27 22:46:37 PDT 
Comment on attachment 429981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429981&action=review

otherwise looks good as far as I can understand

> Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:262
> +                                     const TType  *argType2 = nullptr)

two spaces here :)

> LayoutTests/ChangeLog:9
> +        * fast/canvas/webgl/shader-mix-with-bool-expected.txt: Added.

you didn't add the test case :)
Comment 4 Kyle Piddington 2021-05-28 10:49:15 PDT 
Created attachment 430028 [details]
Patch
Comment 5 EWS 2021-06-02 10:01:56 PDT 
Committed r278362 (238392@main): <https://commits.webkit.org/238392@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430028 [details].
Comment 6 Radar WebKit Bug Importer 2021-06-02 10:02:20 PDT 
<rdar://problem/78769564>