Bug 226356 - [GPU Process] Add debug logging around some shared display list codepaths
Summary: [GPU Process] Add debug logging around some shared display list codepaths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-27 14:20 PDT by Wenson Hsieh
Modified: 2021-05-27 22:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.25 KB, patch)
2021-05-27 14:36 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For EWS (11.23 KB, patch)
2021-05-27 16:56 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-05-27 14:20:27 PDT 
Add log messages to assist with basic triage and debugging.
Comment 1 Wenson Hsieh 2021-05-27 14:36:59 PDT 
Created attachment 429930 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-05-27 15:11:49 PDT 
Comment on attachment 429930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429930&action=review

> Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:96
> +            LOG(SharedDisplayLists, "Acknowledging Flush{%" PRIu64 "} in Image(%" PRIu64 ")", identifier.toUInt64(), m_renderingResourceIdentifier.toUInt64());

LOG_WITH_STREAM avoids the need for PRIu64 shenanigans.
Comment 3 Wenson Hsieh 2021-05-27 15:25:20 PDT 
Comment on attachment 429930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429930&action=review

>> Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:96
>> +            LOG(SharedDisplayLists, "Acknowledging Flush{%" PRIu64 "} in Image(%" PRIu64 ")", identifier.toUInt64(), m_renderingResourceIdentifier.toUInt64());
> 
> LOG_WITH_STREAM avoids the need for PRIu64 shenanigans.

Sounds good! Will change these to use `LOG_WITH_STREAM`.
Comment 4 Wenson Hsieh 2021-05-27 16:56:12 PDT 
Created attachment 429957 [details]
For EWS
Comment 5 EWS 2021-05-27 22:26:31 PDT 
Committed r278191 (238234@main): <https://commits.webkit.org/238234@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429957 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-27 22:27:17 PDT 
<rdar://problem/78604419>