Bug 226353 – Print bot configuration in build.webkit.org builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Print bot configuration in build.webkit.org builds (e.g.: OS/xcode version, uptime, disk-space etc.), similar to how we print in EWS builds. This would help in debugging any bot related issues.

[Aakash Jain]

Created attachment 429922 [details]
[fast-cq] Patch

[Aakash Jain]

Sample runs: https://build.webkit-dev.org/#/builders/17/builds/65

[Jonathan Bedard]

(In reply to Aakash Jain from comment #2)
> Sample runs: https://build.webkit-dev.org/#/builders/17/builds/65

I notice that the linked run prints out watchOS information, but the run is associated with the iPad queue? What's going on with that?

[Aakash Jain]

Not sure. The bot might have multiple SDKs installed.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #4)
> Not sure. The bot might have multiple SDKs installed.

I didn't look at the entire log. You're dumping all installed SDKs, so that makes sense. Is the goal here just to have this information accessible if someone needs it?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #5)
> Is the goal here just to have this information accessible if someone needs it?
Yes

[Alexey Proskuryakov]

Comment on attachment 429922 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429922&action=review

> Tools/CISupport/build-webkit-org/steps_unittest.py:1203
> +            + ExpectShell.log('stdio', stdout='''Upon execvpe sw_vers ['sw_vers'] in environment id 7696545650400
> +:Traceback (most recent call last):
> +  File "/usr/lib/python2.7/site-packages/twisted/internet/process.py", line 445, in _fork
> +    environment)
> +  File "/usr/lib/python2.7/site-packages/twisted/internet/process.py", line 523, in _execChild
> +    os.execvpe(executable, args, environment)
> +  File "/usr/lib/python2.7/os.py", line 355, in execvpe
> +    _execvpe(file, args, env)
> +  File "/usr/lib/python2.7/os.py", line 382, in _execvpe
> +    func(fullname, *argrest)
> +OSError: [Errno 2] No such file or directory'''),

This seems surprising. Not sure if I understand the logic of the test.

[Aakash Jain]

Comment on attachment 429922 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429922&action=review

>> Tools/CISupport/build-webkit-org/steps_unittest.py:1203
>> +OSError: [Errno 2] No such file or directory'''),
> 
> This seems surprising. Not sure if I understand the logic of the test.

The exact error doesn't matter in this test. We are looking at the exit code (1) of the command, and ensure that the step result is 'FAILURE' and description (state_string) is 'Failed to print configuration'. 

This code is being copied from https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/steps_unittest.py#L3709
At that time I would have copied this particular error log from some bot having issues.

Note that long-term we want to share buildbot configuration between ews and build.webkit.org, but that would be a separate effort.

[EWS]

Committed r278310 (238347@main): <https://commits.webkit.org/238347@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429922 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78718168>