Bug 226346 - [Hardening] Use a RELEASE_ASSERT for SharedBufferDataView constructor
Summary: [Hardening] Use a RELEASE_ASSERT for SharedBufferDataView constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-27 11:05 PDT by Brent Fulgham
Modified: 2021-05-27 16:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2021-05-27 13:04 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-05-27 11:05:38 PDT 
We have a DEBUG assert in the constructor for SharedBufferDataView. Debug test bots don't hit this, and it's not a particularly hot code path. We should make it a release assert.
Comment 1 Brent Fulgham 2021-05-27 11:05:59 PDT 
<rdar://problem/78115298>
Comment 2 Brent Fulgham 2021-05-27 13:04:30 PDT 
Created attachment 429914 [details]
Patch
Comment 3 EWS 2021-05-27 16:03:41 PDT 
Committed r278180 (238223@main): <https://commits.webkit.org/238223@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429914 [details].