Bug 226333 - [GTK4] Make favicon and snapshot API use GdkTexture instead of cairo surfaces
Summary: [GTK4] Make favicon and snapshot API use GdkTexture instead of cairo surfaces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2021-05-27 08:19 PDT by Alice Mikhaylenko
Modified: 2023-02-08 00:57 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Mikhaylenko 2021-05-27 08:19:26 PDT 
See https://bugs.webkit.org/show_bug.cgi?id=212327#c12

>  Hm, do you think we should create a bug to change webkit_web_view_get_snapshot_finish() to return a GdkTexture rather than a cairo_surface_t? It might be nice to remove cairo from WebKit's API?

> (We'd of course want to do that in a separate bug, not here. It will be a bit hard because I think gtk-doc cannot handle conditional compilation. We will blow its little mind.)
Comment 1 Carlos Garcia Campos 2023-02-07 03:55:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9747
Comment 2 EWS 2023-02-08 00:57:29 PST 
Committed 259997@main (d15c97f78b03): <https://commits.webkit.org/259997@main>

Reviewed commits have been landed. Closing PR #9747 and removing active labels.