Bug 226313 – Sampled Page Top Color: allow snapshotting of elements with CSS animations/transitions if they're paused

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Devin Rousso]

.

[Devin Rousso]

<rdar://problem/78534076>

[Devin Rousso]

Created attachment 429836 [details]
Patch

[Tim Horton]

Comment on attachment 429836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429836&action=review

> Source/WebCore/ChangeLog:12
> +        animation/transition is. This is only really an issue for CSS animations/transitions that
> +        are actively running, not ones that have yet to run or have finished.

Kinda weird logic? It's a race; if the animation wins the race all the way, you're treating it like the race never happened?

(if you snapshot the same page twice, and catch it in the animation the first time, and after the animation is done the second time, you'll get two different colors after your patch where you would have gotten the same color before it?)

(I also don't know that any of this is at all important)

[Devin Rousso]

Created attachment 429967 [details]
Patch

[EWS]

Committed r278189 (238232@main): <https://commits.webkit.org/238232@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429967 [details].

[Darin Adler]

Comment on attachment 429967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429967&action=review

> Source/WebCore/page/PageColorSampler.cpp:31
> +#include "Element.h"

This should not be needed. HTMLCanvasElement and HTMLIFrameElement are both derived from Element, so there would be no need to include the "grand-base" class too.