Bug 226309 - [Win] Remove unused GraphicsContext::hdc()
Summary: [Win] Remove unused GraphicsContext::hdc()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 17:55 PDT by Fujii Hironori
Modified: 2021-06-01 14:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2021-05-26 17:56 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2021-05-31 13:52 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch for landing (2.33 KB, patch)
2021-06-01 13:27 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-05-26 17:55:38 PDT 
[Win] Remove unused GraphicsContext::hdc()
Comment 1 Fujii Hironori 2021-05-26 17:56:59 PDT 
Created attachment 429820 [details]
Patch
Comment 2 Fujii Hironori 2021-05-26 19:44:08 PDT 
Comment on attachment 429820 [details]
Patch

AppleWin EWS failed. It is still used.

C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebKitLegacy\win\Plugins\PluginViewWin.cpp(557,8): error C2039: 'hdc': is not a member of 'WebCore::GraphicsContext' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
Comment 3 Fujii Hironori 2021-05-30 21:16:09 PDT 
(In reply to Fujii Hironori from comment #2)
> AppleWin EWS failed. It is still used.

r278265 removed the code.
Comment 4 Fujii Hironori 2021-05-31 13:52:53 PDT 
Created attachment 430212 [details]
Patch
Comment 5 Fujii Hironori 2021-06-01 13:27:42 PDT 
Created attachment 430286 [details]
Patch for landing
Comment 6 EWS 2021-06-01 14:04:44 PDT 
Committed r278328 (238361@main): <https://commits.webkit.org/238361@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430286 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-01 14:05:20 PDT 
<rdar://problem/78731782>