Bug 226301 - [iOS] Preprocess the WebContent sandbox
Summary: [iOS] Preprocess the WebContent sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 15:37 PDT by Per Arne Vollan
Modified: 2021-06-01 08:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (135.64 KB, patch)
2021-05-26 15:42 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (135.04 KB, patch)
2021-05-26 15:44 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (136.44 KB, patch)
2021-05-26 15:47 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (136.44 KB, patch)
2021-05-26 16:17 PDT, Per Arne Vollan 		ggaren: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (138.78 KB, patch)
2021-05-29 07:27 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (138.60 KB, patch)
2021-05-29 07:35 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-05-26 15:37:17 PDT 
Run the WebContent sandbox through the preprocessor on iOS.
Comment 1 Per Arne Vollan 2021-05-26 15:42:01 PDT 
Created attachment 429805 [details]
Patch
Comment 2 Per Arne Vollan 2021-05-26 15:44:34 PDT 
Created attachment 429806 [details]
Patch
Comment 3 Per Arne Vollan 2021-05-26 15:47:56 PDT 
Created attachment 429807 [details]
Patch
Comment 4 Per Arne Vollan 2021-05-26 16:17:10 PDT 
Created attachment 429811 [details]
Patch
Comment 5 Geoffrey Garen 2021-05-27 09:42:21 PDT 
Comment on attachment 429811 [details]
Patch

r=me
Comment 6 Brent Fulgham 2021-05-27 09:56:00 PDT 
Comment on attachment 429811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429811&action=review

It looks like this just adds the preprocessing step, but doesn't take any action at present -- is that right?

> Source/WebKit/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=226301

Can you include the radar here?

> Source/WebKit/ChangeLog:8
> +        Run the WebContent sandbox through the preprocessor on iOS.

It doesn't appear that we have any conditional compilation here yet, right? It seems like this patch is just about doing the preprocessing (which does nothing in this patch).
Comment 7 Radar WebKit Bug Importer 2021-05-27 10:26:55 PDT 
<rdar://problem/78575178>
Comment 8 Per Arne Vollan 2021-05-29 07:27:23 PDT 
Created attachment 430092 [details]
Patch
Comment 9 Per Arne Vollan 2021-05-29 07:35:30 PDT 
Created attachment 430093 [details]
Patch
Comment 10 Per Arne Vollan 2021-05-29 07:39:24 PDT 
(In reply to Geoffrey Garen from comment #5)
> Comment on attachment 429811 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 11 Per Arne Vollan 2021-05-29 07:40:02 PDT 
(In reply to Brent Fulgham from comment #6)
> Comment on attachment 429811 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429811&action=review
> 
> It looks like this just adds the preprocessing step, but doesn't take any
> action at present -- is that right?
> 
> > Source/WebKit/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=226301
> 
> Can you include the radar here?
> 

Done!

> > Source/WebKit/ChangeLog:8
> > +        Run the WebContent sandbox through the preprocessor on iOS.
> 
> It doesn't appear that we have any conditional compilation here yet, right?
> It seems like this patch is just about doing the preprocessing (which does
> nothing in this patch).

Yes, that is correct. 

Thanks for reviewing!
Comment 12 EWS 2021-06-01 08:19:45 PDT 
Committed r278308 (238345@main): <https://commits.webkit.org/238345@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430093 [details].