Bug 226300 - Cleanup temporary directory after TestWTF's FileSystemTests
Summary: Cleanup temporary directory after TestWTF's FileSystemTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 15:37 PDT by Stephan Szabo
Modified: 2021-05-26 17:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2021-05-26 15:39 PDT, Stephan Szabo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2021-05-26 15:37:03 PDT 
Some tests like FileSystemTest.moveFile, the m_tempEmptyFolderPath is used as a destination and may not get cleaned if the file still exists at the end of the test since it's no longer empty, so move to using deleteNonEmptyDirectory during cleanup.
Comment 1 Stephan Szabo 2021-05-26 15:39:45 PDT 
Created attachment 429804 [details]
Patch
Comment 2 Chris Dumez 2021-05-26 15:47:14 PDT 
Comment on attachment 429804 [details]
Patch

r=me
Comment 3 EWS 2021-05-26 17:35:47 PDT 
Committed r278138 (238183@main): <https://commits.webkit.org/238183@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429804 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-26 17:36:19 PDT 
<rdar://problem/78542451>